[Fedback needed]Minor updates to ASSIMP Viewer #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine for me. Just give me a ping when I shall merge it. |
Removed dead link and updated copyright string in the About dialog.
Windres handles it just fine, with the intended result, but RC doesn't seem to like it.
|
@kimkulling Done! |
kimkulling
approved these changes
May 9, 2022
| @@ -96,7 +96,7 @@ IF ( MSVC ) | |||
| ENDIF () | |||
|
|
|||
| # Link the executable to the assimp + dx libs. | |||
| TARGET_LINK_LIBRARIES ( assimp_viewer assimp ${DirectX_LIBRARY} ${DirectX_D3DX9_LIBRARY} comctl32.lib winmm.lib ) | |||
| TARGET_LINK_LIBRARIES ( assimp_viewer assimp ${DirectX_LIBRARY} ${DirectX_D3DX9_LIBRARY} comctl32 winmm ) | |||
|
Merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much the same as #4510 except I was more careful, since this is a GUI application that very much relies on the script for its UI. Also replaced some SourceForge references to GitHub.