Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilizies AI_CONFIG_IMPORT_REMOVE_EMPTY_BONES flag for Collada meshes. #4585

Merged
merged 4 commits into from Jun 23, 2022

Conversation

onurtore
Copy link
Contributor

@onurtore onurtore commented Jun 21, 2022

Hi!
I am a GSoC student working under Open Source Robotics Foundation. As a part of my project we are trying to utilize Assimp as default mesh loader for the Gazebo Physics simulator. We have problems with missing bones and I am trying to solve this problem by either 1) Utilizing flags related to bone removal codes or 2) Utilizing newly created experimental bone structure. While I am trying to fix this by doing n.1, if you think n.2 is better, we would love to hear it and help the development of that path.

Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will merge it! Thanks a lot for implementing this.

@kimkulling
Copy link
Member

Great work, thanks a lot for your help. I will merge this PR. let me know if the new class aiSkeleton will be interesting for you as well. Maybe we can try to integrate it into the Collada-Importer as well.

@kimkulling kimkulling merged commit 038ae8c into assimp:master Jun 23, 2022
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants