Build fix for compiling against minizip. #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From v5.1.6 onwards Assimp fails to build on my Ubuntu 21.10 system's default minizip install. Looking at Issues tracker, #4334, others have the same build problem on a range of Linux distos. I've added a #ifdef check around the problematic line to keep things compiling.
Unfortunately this #ifdef approach looks like it'll disable the functionality that caused this break in the build - I don't know how intrusive this would be as I'm not familiar with the wider code, there may well be more changes that would need disabling or handling to more elegantly handle these features that can't be implemented against minizip.
I provide this build fix so that others who are hitting up against the same problem can at least get Assimp built.