Fixes Heap-use-after-free in Assimp::DXFImporter::ExpandBlockReferences #4644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Heap-use-after-free in Assimp::DXFImporter::ExpandBlockReferences revealed by fuzzing:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=42899
The root cause is that
bl_src.lines
andbl.lines
inDXFImporter::ExpandBlockReferences
may be the same vector. Iterator may become invalid when new objects are pushed into the same vector.