Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BlenderDNA.h] Declare explicit specializations #4816

Merged
merged 2 commits into from Nov 30, 2022

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Nov 29, 2022

It is an ODR violation to use a template specialization for which an explicit specialization is defined somewhere whose declaration is not visible at the point of use.

Found via clang's -Wundefined-func-template warning.

tkoeppe and others added 2 commits November 29, 2022 18:38
It is an ODR violation to use a template specialization for which an
explicit specialization is defined somewhere whose declaration is not
visible at the point of use.

Found via clang's -Wundefined-func-template warning.
@kimkulling kimkulling merged commit b0987f4 into assimp:master Nov 30, 2022
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 30, 2022

My great pleasure!

@tkoeppe tkoeppe deleted the explspec branch November 30, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants