Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

illegal token on right-side-of ::Windows #4846

Merged
merged 2 commits into from Dec 19, 2022
Merged

illegal token on right-side-of ::Windows #4846

merged 2 commits into from Dec 19, 2022

Conversation

rohit-kumar-j
Copy link
Contributor

Error without:

assimp\material.inl(101,47): message : error recovery skipped: ') ?'

Reference : https://stackoverflow.com/questions/2561368/illegal-token-on-right-side-of

rohit-kumar-j and others added 2 commits December 19, 2022 04:06
@rohit-kumar-j
illegal token on right-side-of ::Windows
6743274 
Error without:
```
assimp\material.inl(101,47): message : error recovery skipped: ') ?'
```

Reference : https://stackoverflow.com/questions/2561368/illegal-token-on-right-side-of
@kimkulling
Update material.inl
76de8ba
kimkulling
kimkulling approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the undef max. Seems that only min is causing the problem.

@kimkulling kimkulling merged commit 022c385 into assimp:master Dec 19, 2022
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

@rohit-kumar-j rohit-kumar-j deleted the patch-1 branch December 19, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohit-kumar-j @kimkulling