Generalize JoinVerticesProcess for multiple UV and color channels #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the current master branch,
JoinVerticesProcesssilently ignores all UV channels except the first as well as all color channels. This causes vertices to be merged unexpectedly if they differ only in one of those attributes. There is a parameter in the local comparison functionareVerticesEqualwhich enables the associated checks but it is always set tofalse.The proposed change replaces the stateless comparator used in
JoinVerticesProcess::ProcessMeshwith one that caches the number of UV and color channels in the current mesh. This allowsareVerticesEqualto check all relevant vertex attributes without performing unnecessary comparisons.