Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test warning fixes #4932

Merged
merged 2 commits into from Feb 2, 2023
Merged

Unit test warning fixes #4932

merged 2 commits into from Feb 2, 2023

Conversation

turol
Copy link
Member

@turol turol commented Feb 2, 2023

GCC was warning about possibly uninitialized variables. Initialize them and use values which are nonzero and distinct from each other and any real value passed to any set method. This should prevent any false positives from zero initialization.

GCC was warning about possibly uninitialized variables. Initialize them
and use values which are nonzero and distinct from each other and any
real value passed to any set method. This should prevent any false positives
from zero initialization.
@turol turol requested a review from kimkulling February 2, 2023 12:37
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, many thanks!

@kimkulling kimkulling merged commit dbd0ae8 into assimp:master Feb 2, 2023
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

@turol turol deleted the unit-test-fix branch February 3, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants