Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWO fixes #4977

Merged
merged 9 commits into from Feb 27, 2023
Merged

LWO fixes #4977

merged 9 commits into from Feb 27, 2023

Conversation

turol
Copy link
Member

@turol turol commented Feb 24, 2023

Cleans up LWO loader a bit, adds debug logging and closes a bug that prevented loading LWOB files. I'm not entirely sure if this is the right fix but it seems to work.

Closes #1196

@turol
Copy link
Member Author

turol commented Feb 24, 2023

@tellypresence @darkf Please test if this works for you.

Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me. Indeed, the loader seems to need some more love and refactoring.

@kimkulling kimkulling merged commit 9033334 into assimp:master Feb 27, 2023
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

@turol turol deleted the lwo-fixes branch February 27, 2023 20:11
@turol
Copy link
Member Author

turol commented Feb 28, 2023

Yes, this loop:

for (auto itMapParentNodes = apcNodes.begin(); itMapParentNodes != apcNodes.end(); ++itMapParentNodes) {

Looks suspiciously O(n^2)
However currently nothing triggers pathological behavior and it's really hard to understand what's actually happening here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LWOB loader appears broken (LWO: Unable to build a valid node graph)
2 participants