New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LWO fixes #4977
LWO fixes #4977
Conversation
@tellypresence @darkf Please test if this works for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me. Indeed, the loader seems to need some more love and refactoring.
Merged, thanks a lot for your contribution. |
Yes, this loop: assimp/code/AssetLib/LWO/LWOLoader.cpp Line 630 in 9033334
Looks suspiciously O(n^2) However currently nothing triggers pathological behavior and it's really hard to understand what's actually happening here. |
Cleans up LWO loader a bit, adds debug logging and closes a bug that prevented loading LWOB files. I'm not entirely sure if this is the right fix but it seems to work.
Closes #1196