Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix the three vertices are collinear #4979

Merged
merged 2 commits into from Mar 12, 2023
Merged

Conversation

Jackie9527
Copy link
Contributor

The three vertices are collinear when converting a polygon to a triangle, which is weird but indeed exists.
Currently, we just skip such ear.

…a triangle.

Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@kimkulling kimkulling merged commit fdcc45d into assimp:master Mar 12, 2023
11 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

@Jackie9527 Jackie9527 deleted the 1-3458 branch March 13, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants