Fix link issue in UWP builds without functional replacement #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The used API is marked as deprecated. I guess I need to update the used dependency here. Thanks for figuring this out. The used function is not used in our software, so I am fine with the fix. |
|
Merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying a version update from 5.2.5 I discovered some build issues if included in UWP projects.
I come up with a simple solution, skipping just the missing function in windows libraries. There seems to be some system function in UWP to get a similar behavior.
For me, it doesn't matter if this function is executed that way. If there is a way to just not include unzip code or replace with UWP support, I didn't find it the last days.