Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning related to unreachable-code-break. #5046

Merged
merged 8 commits into from Apr 20, 2023
Merged

Fix warning related to unreachable-code-break. #5046

merged 8 commits into from Apr 20, 2023

Conversation

Jackie9527
Copy link
Contributor

Fix the following warnings when -Wno-unreachable-code-break is removed.

D:\workspace\CODE\assimp\code\PostProcessing\ValidateDataStructure.cpp(293,17): error : 'break' will never be executed
[-Werror,-Wunreachable-code-break] [D:\workspace\CODE\assimp\build-msvc-clang\code\assimp.vcxproj]

D:\workspace\CODE\assimp\code\AssetLib\Collada\ColladaParser.cpp(1858,13): error : 'break' will never be executed [-Wer
ror,-Wunreachable-code-break] [D:\workspace\CODE\assimp\build-msvc-clang\code\assimp.vcxproj]

@Jackie9527 Jackie9527 changed the title Msvc clang unreachable code break Fix warning related to unreachable-code-break. Apr 1, 2023
@Jackie9527
Fix warning related to unreachable-code-break.
0148804 
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
@Jackie9527
Fix warning related to unreachable-code-break.
9e80dfc 
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
@Jackie9527
Fix warning related to unreachable-code-break.
7620a69 
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
@Jackie9527
Fix warning related to unreachable-code-break.
cec41f6 
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
@Jackie9527
Fix warning related to unreachable-code-break.
0a05a1f 
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
@Jackie9527
Fix warning related to unreachable-code-break.
12bc34a 
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
@Jackie9527
Fix warning related to unreachable-code-break.
4d96205 
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
@Jackie9527
Remove -Wno-unreachable-code-break.
1b826af 
Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
@Jackie9527 Jackie9527 force-pushed the msvc-clang-unreachable-code-break branch from 3c096b8 to 1b826af Compare April 19, 2023 14:27
kimkulling
kimkulling approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@kimkulling kimkulling merged commit 87a288e into assimp:master Apr 20, 2023
11 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jackie9527 @kimkulling