Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Wno-deprecated-copy-with-dtor. #5051

Merged

Conversation

Jackie9527
Copy link
Contributor

@Jackie9527 Jackie9527 commented Apr 1, 2023

Remove unused -Wno-deprecated-copy-with-dtor.

Signed-off-by: Jackie9527 <80555200+Jackie9527@users.noreply.github.com>
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@Jackie9527
Copy link
Contributor Author

Jackie9527 commented Apr 26, 2023

I guess it is conflicted with #5048, which will be fixed ASAP.

@kimkulling kimkulling merged commit 9c2594a into assimp:master Apr 26, 2023
11 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants