Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible dereferencing of invalid pointer. #5066

Merged
merged 1 commit into from Apr 17, 2023
Merged

Fix possible dereferencing of invalid pointer. #5066

merged 1 commit into from Apr 17, 2023

Conversation

kimkulling
Copy link
Member

@turol
Copy link
Member

turol commented Apr 17, 2023

This doesn't look like it should fix anything. unique_ptr is generally safer than explicit new/delete Have you tested that it fixes the test case? Can you put the testcase somewhere where it can be freely downloaded?

@turol
Copy link
Member

turol commented Apr 17, 2023

Looks like google has fixed their crap and it's now possible to download testcases without login.

@kimkulling kimkulling merged commit 333f7d5 into master Apr 17, 2023
11 checks passed
@turol
Copy link
Member

turol commented Apr 17, 2023

This did not fix the bug and might have introduced memory leaks in error paths by removing unique_ptr. Please revert.

@kimkulling kimkulling deleted the kimkulling/fix_possible_invalid_dereferencing_of-issue-4918 branch April 26, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
The Asset-Importer-Lib Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Issue 54900 in oss-fuzz: assimp:assimp_fuzzer: Abrt in aiMesh::~aiMesh
2 participants
@kimkulling @turol