Fix Bad-cast to Assimp::D3DS::Material from invalid vptr in Assimp::ASE::Parser::ParseLV2MaterialBlock #5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SE::Parser::ParseLV2MaterialBlock
sashashura
force-pushed
the
5921493454815232
branch
from
48b80d6
to
86aecf3
Compare
|
Merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=47171
Closes #4694
The root cause is that
iMaterialCountfromParseLV4MeshLong(iMaterialCount);is very large andm_vMaterials.resize(iOldMaterialCount + iMaterialCount, ...)overflows the integer. Instead of increasing the size ofm_vMaterials, the vector is resized to a small number of elements. LaterMaterial &sMat = m_vMaterials[iIndex + iOldMaterialCount];takes a reference to a non-existing element of the vector (out of bounds vector read).