Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing config property lookup for removal of empty bones. #5133

Conversation

Biohazard90
Copy link
Contributor

The post processing step LimitBoneWeightsProcess currently always removes unused bones because the config property AI_CONFIG_IMPORT_REMOVE_EMPTY_BONES has not been used to toggle this behavior on and off.

This change adds a property look up so LimitBoneWeightsProcess won't remove unused bones anymore when the client doesn't want this behavior.

Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A much better to do it this way. Thanks a lot! I will merge it.

@kimkulling kimkulling merged commit 49a6eec into assimp:master Jun 7, 2023
11 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants