Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling for negative indices. #5146

Merged
merged 6 commits into from Jun 20, 2023
Merged

Add handling for negative indices. #5146

merged 6 commits into from Jun 20, 2023

Conversation

kimkulling
Copy link
Member

@kimkulling kimkulling merged commit b94392d into master Jun 20, 2023
11 checks passed
@kenichiice
Copy link
Contributor

@kimkulling
This PR currently skips faces with negative indices. However, it is the 'edges' that become invisible due to negative indices. Shouldn't the faces still need to be constructed?

@kimkulling kimkulling deleted the kimkulling/dxf_handling_for_invisible_faces_issue-2036 branch August 30, 2023 21:18
@kenichiice kenichiice mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
The Asset-Importer-Lib Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR, DXF IMPORT
2 participants
@kimkulling @kenichiice