Bug fix and improvement to FBX camera field-of-view during import. #5175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Width and focalLength if FOV not specified.
kimkulling
requested changes
Jul 23, 2023
code/AssetLib/FBX/FBXDocument.h
Outdated
| @@ -55,9 +55,13 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
| #define _AI_CONCAT(a,b) a ## b | |||
| #define AI_CONCAT(a,b) _AI_CONCAT(a,b) | |||
|
|
|||
| /* Use an 'illegal' default FOV value to detect if the FBX camera has set the FOV. */ | |||
There was a problem hiding this comment.
Please use // style comments. This will make it much easier to put bigger blocks into comments.
|
Merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For FBX files, mHorizontalFOV was being computed from the full field-of-view, not from the center to the edge. Scaled by 0.5.
Also, some software (Maya) does not put the field-of-view in FBX, but it can be computed from focal length and image width. This patch detects if FOV hasn't been set in the file and computes it.
This is not an exhaustive fix to FBX cameras, but is an improvement for common uses.