Collada: added import property to disable unit size scaling #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no need to merge master branch, we will do that when we're ready to merge. If you want to update your branch prefer rebase and force push to avoid excessive amount of merge commits. |
|
Ah sorry. I thought I hit the rebase option through the Github web interface. I will refrain from further updates. |
|
So, I have merged the current master. Now I will start doing the code review. |
|
Merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the option to ignore the unit size scaling for Collada imports.
This PR adds a property
AI_CONFIG_IMPORT_COLLADA_IGNORE_UNIT_SIZEwhich controls if the unit size scaling is applied to the root node's transform or not. It works similar to the existingAI_CONFIG_IMPORT_COLLADA_IGNORE_UP_DIRECTIONproperty.The default value is false, so the behavior for Collada imports will not change unless explicitly requested.