Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Triangulate Process #5205

Merged
merged 1 commit into from Aug 30, 2023
Merged

Update Triangulate Process #5205

merged 1 commit into from Aug 30, 2023

Conversation

aaronmack
Copy link
Contributor

image

According to the current Ear Clipping algorithm, point 2 is not within triangle 5, 9, 11, But point 2 is on the edge of 5-11. In this case, the triangle generated will cover the hole on the right.

I modified the OnLeftSideOfLine2D function so that it can determine whether it is left or right or on the side.

Here are the results of the test.

image

And this is the FBX file that I tested.

double_hold.zip

@kimkulling kimkulling mentioned this pull request Aug 30, 2023
@kimkulling kimkulling merged commit 8c8f974 into assimp:master Aug 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants