Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of skinning data export to GLB/GLTF format #5243

Merged
merged 8 commits into from
Oct 8, 2023

Conversation

fvbj
Copy link
Contributor

@fvbj fvbj commented Sep 22, 2023

Allows to export unlimited (more than 4) bones per vertex.
Uses JOINTS_1,2,.. and WEIGHTS_1,2,... attributes.
Adds AI_CONFIG_EXPORT_GLTF_UNLIMITED_SKINNING_BONES_PER_VERTEX flag to enable the extension.
Adds a simple test file and tests to check the functionality.

Allows to export unlimited (more than 4) bones per vertex
Use JOINTS_1,2,.. and WEIGHTS_1,2,...
Added AI_CONFIG_EXPORT_GLTF_UNLIMITED_SKINNING_BONES_PER_VERTEX flag
@fvbj fvbj changed the title Extension of data export to GLB/GLTF format Extension of skinning data export to GLB/GLTF format Oct 3, 2023
@kimkulling
Copy link
Member

There is an issue with implicit conversion from double to float.

Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@kimkulling kimkulling merged commit 5d60cf2 into assimp:master Oct 8, 2023
11 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants