Rm unnecessary deg->radian conversion in FBX exporter #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianKnodt
changed the title
JulianKnodt
changed the title
JulianKnodt
force-pushed
the
master
branch
2 times, most recently
from
7e4f809
to
61c7d40
Compare
|
I'll need to double check tmrw if this is correct, but should be good to review now. |
JulianKnodt
commented
Oct 17, 2023
It seems that rotation matrices later expect radians. This conversion breaks it, and was validated on the conversion of `cesium_man.glb` --> `cesium_man.fbx`
|
-merged, thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that rotation matrices later expect radians. This conversion breaks it, and was validated on the conversion of
cesium_man.glb-->cesium_man.fbxcc @ronenv-ten @gongminmin
closes #5137
EDIT: actually, I found that for animated meshes, this works. For meshes without animations, this seems to break things. Will continue to investigate further.
EDIT 2: This actually can be fixed entirely within
FBXConverter.cppby converting deg to rad on 3219, 3242, and 3250, will get to it tonight.