FBXMeshGeometry: solve issue #5116 using patch provided by darktjm #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your PR! And sorry for my late response. I am trying to help keep this project running at night. Currently, I am not good at it. |
|
Merged, thanks a lot for your contribution. |
|
Thanks, @kimkulling. I've acted as release manager for other GitHub projects and know it can get overwhelming. I encourage work at your own pace and not allow anyone to rush you. The alternative is burnout. In my opinion, tjm's sarcastic comments at 5116 were unprofessional and uncalled for. I hope you didn't take them to heart. In my opinion, the right path is to let go of one's ego and focus on what's best for the project. In this case, that means accepting tjm's help and crediting them for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the fix for issue #5116 that was proposed by @darktjm on 8 September.