Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KHR_materials_specular fixes #5347

Merged
merged 4 commits into from
Dec 11, 2023
Merged

KHR_materials_specular fixes #5347

merged 4 commits into from
Dec 11, 2023

Conversation

rudybear
Copy link
Contributor

I found 2 issues while exporting the official assets ( https://github.com/KhronosGroup/glTF-Sample-Assets/tree/main/Models/SpecularTest)

  1. It doesn't provide proper properties for an extension, default values are different in the spec
  2. It overrides the Specular texture type (specular and specularColor by the spec are separate)

kimkulling
kimkulling approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@kimkulling kimkulling merged commit 762ad8e into assimp:master Dec 11, 2023
11 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
The Asset-Importer-Lib Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rudybear @kimkulling