Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve acc file loading #5360

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Improve acc file loading #5360

merged 4 commits into from
Jan 9, 2024

Conversation

IOBYTE
Copy link
Contributor

@IOBYTE IOBYTE commented Nov 30, 2023

Add warning and support for tolerating a common problem where objects have wrong kid count. Add support for empty texture layers.

Add warning and support for tolerating a common problem where objects have wrong kid count.
Add support for empty texture layers.
@IOBYTE
Copy link
Contributor Author

IOBYTE commented Nov 30, 2023

This also fixes a problem where degenerate triangles were being deleted causing a validation error for meshes with no vertices.

Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@kimkulling kimkulling merged commit 81c20a5 into assimp:master Jan 9, 2024
8 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants