Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KHR_materials_pbrSpecularGlossiness/diffuseFactor convert to pbr… #5410

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

guguTang
Copy link

@guguTang guguTang commented Jan 5, 2024

When there is KHR_materials_pbrSpecularGlossiness and AI_CONFIG_USE_GLTF_PBR_SPECULAR_GLOSSINESS is false, Converting the KHR_materials_pbrSpecularGlossiness/diffuseFactor pbrMetallicRoughness/baseColorFactor

Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@kimkulling kimkulling merged commit 9776d47 into assimp:master Jan 5, 2024
8 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants