-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #5461 (segfault after removing redundant materials) #5467
Conversation
- Fix 2 possible memleaks.
During the review I have detected 2 leaks. |
@kimkulling Thanks for solving the memory leaks. |
Hm, tests are failing for g++ on Ubuntu. I cannot reproduce it on windows. I will try to analyze it with Linux. |
I tried to reproduce the test failure on my Linux desktop and was unsuccessful: all 574 tests passed. |
It seems my merge solved the test failure! |
After another merge from 'master', the tests are failing again. |
Once again, merging has solved the failing checks. Please integrate this PR. |
After another merge from 'master', another failing check. |
Once again, merging has solved the failing checks. @kimkulling please integrate this PR. |
Updated again, let's hope that the tests are green. |
Merged, thanks a lot for your contribution. |
Update
mNumMaterials
before early return fromRemoveRedundantMatsProcess::Execute()
.