Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix utDefaultIOStream test under MinGW #5525

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Fix utDefaultIOStream test under MinGW #5525

merged 1 commit into from
Apr 6, 2024

Conversation

thenanisore
Copy link
Contributor

@thenanisore thenanisore commented Apr 2, 2024 •
edited
Loading

utDefaultIOStream.FileSizeTest fails on MinGW's GCC, since it assumes a *nix OS and tries to create a temporary file at /tmp/rndfp.XXXXXX. There're many other places which checks for MINGW macros, so I guess it wasn't intentional.

[==========] 574 tests from 115 test suites ran. (16450 ms total)
[  PASSED  ] 573 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] utDefaultIOStream.FileSizeTest

 1 FAILED TEST

Similar logic is used in utIOStreamBuffer.cpp, although there it just creates the files in the cwd without any TMP_PATH.

@thenanisore thenanisore force-pushed the thenanisore/fix-utdefaultiostream-test branch from 2447392 to d86fc7d Compare April 2, 2024 16:43
kimkulling
kimkulling approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lokks fine.

@kimkulling kimkulling added Testing Global flag to mark testing topics Bug Global flag to mark a deviation from expected behaviour labels Apr 3, 2024
@kimkulling kimkulling merged commit 9d11b22 into assimp:master Apr 6, 2024
8 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

@miccal miccal mentioned this pull request Apr 7, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
Bug Global flag to mark a deviation from expected behaviour Testing Global flag to mark testing topics
Projects
The Asset-Importer-Lib Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thenanisore @kimkulling