Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SplitByBoneCount typo that prevented node updates #5550

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix SplitByBoneCount typo that prevented node updates #5550

merged 1 commit into from
Apr 23, 2024

Conversation

Succ3s
Copy link
Contributor

@Succ3s Succ3s commented Apr 21, 2024

Due to a == that should have been a != nodes weren't updated after split.

Fixes #5549

kimkulling
kimkulling approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@kimkulling kimkulling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, good catch.

@kimkulling kimkulling merged commit 7bda0f8 into assimp:master Apr 23, 2024
8 checks passed
@kimkulling
Copy link
Member

Merged, thanks a lot for your contribution.

@CientistaVuador CientistaVuador mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimkulling kimkulling kimkulling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
The Asset-Importer-Lib Kanban Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process_SplitByBoneCount only adds one subdivided mesh back
2 participants
@Succ3s @kimkulling