Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ vue-dot: Bind vuetify-options directly in HeaderNavigationDrawer #2688

Merged
merged 1 commit into from Apr 5, 2023

Conversation

deraw
Copy link
Member

@deraw deraw commented Apr 5, 2023

Description

Suppression de la propriété navigationDrawer dans les options Vuetify du composant HeaderNavigationDrawer pour éviter la redondance :

vuetifyOptions = {
	navigationDrawer: {
		navigationDrawer: {
			hideOverlay: Boolean(this.$attrs.sticky && this.$attrs.mobileVersion)
		}
	}
};

Playground

<template>
	<HeaderBar
		:vuetify-options="vuetifyOptions"
		:navigation-items="navigationItems"
	/>
</template>

<script lang="ts">
	import Vue from 'vue';
	import Component from 'vue-class-component';

	import { NavigationItem } from '@cnamts/vue-dot/src/patterns/HeaderBar/types';

	@Component
	export default class Playground extends Vue {
		vuetifyOptions = {
			navigationDrawer: {
				hideOverlay: true
			}
		};

		navigationItems: NavigationItem[] = [
			{
				label: 'Accueil'
			},
			{
				label: 'Mes projets'
			},
			{
				label: 'Mes outils'
			}
		];
	}
</script>

Type de changement

  • Refactoring

Techniquement cela peut-être un changement majeur, mais il s'agit d'une API de personnalisation peut utilisée.

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #2688 (b4ffc5b) into dev (cb63ea2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #2688   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          222       222           
  Lines         1339      1339           
  Branches       165       165           
=========================================
  Hits          1339      1339           
Impacted Files Coverage Δ
...atterns/HeaderBar/HeaderNavigationDrawer/config.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@christopheGaon christopheGaon self-requested a review April 5, 2023 17:01
@christopheGaon christopheGaon merged commit 6a46deb into dev Apr 5, 2023
9 checks passed
@christopheGaon christopheGaon deleted the vue-dot/fix/header-bar-drawer-options branch April 5, 2023 17:02
@deraw deraw added the refactoring Mise à jour du code label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Mise à jour du code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants