Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove findInFiles js-api danger note #308

Closed
wants to merge 2 commits into from

Conversation

sseppola
Copy link

This was fixed almost a year ago according to the PR ast-grep/ast-grep#206 (comment)

@HerringtonDarkholme
Copy link
Member

Hi, thanks for the pull request.
However, the napi limitation was not fixed. We found the issue one year ago but it was still there due to nodejs' implementation.

So I do think the section should be kept.

But thanks for the pull request anyway!

@sseppola
Copy link
Author

Aha, then I misunderstood what was fixed!
I was going to report it as an issue, but figured I may as well make the change instead.

Thanks for making such a cool tool! I appreciate the effort of making ASTs more approachable 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants