Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language): Add support for Haskell via tree-sitter-haskell #1128

Merged
merged 5 commits into from
May 9, 2024

Conversation

fwcd
Copy link
Contributor

@fwcd fwcd commented May 7, 2024

Fixes #1127

This adds support for Haskell by integrating tree-sitter-haskell. While it compiles, even rudimentary patterns such as return $A or $A $B do not work yet (probably an upstream issue?), therefore I will mark this PR as a draft for now.

Copy link
Contributor

coderabbitai bot commented May 7, 2024

Walkthrough

The recent updates to the language crates introduce Haskell language support using tree-sitter-haskell. This includes setting up the necessary configurations, parsers, and testing functionalities for Haskell code, enhancing the ast-grep tool's capabilities to accommodate Haskell-specific syntax and patterns.

Changes

File Path Change Summary
crates/language/Cargo.toml Added support for tree-sitter-haskell version 0.21.0.
crates/language/src/haskell.rs, lib.rs Introduced test functions for Haskell code pattern matching and replacing. Integrated Haskell support into the main library.
crates/language/src/parsers.rs Added language_haskell() function to handle Haskell parsing.

Assessment against linked issues

Objective Addressed Explanation
Add Haskell support (#1127)

🐇🎉
A hop, a skip, in the code we dip,
Haskell's in, let the games begin!
Patterns match, errors we catch,
In Haskell's land, ast-grep stands grand!
🌟📜🔍


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fwcd fwcd changed the title Add support for Haskell via tree-sitter-haskell feat(language): Add support for Haskell via tree-sitter-haskell May 7, 2024
@HerringtonDarkholme
Copy link
Member

Hi @fwcd, thanks for your interest in ast-grep.

You can look at custom language support https://ast-grep.github.io/advanced/custom-language.html for supporting haskell.

It is probable you need to configure the expandoChar option.

@fwcd fwcd marked this pull request as ready for review May 8, 2024 00:51
@fwcd
Copy link
Contributor Author

fwcd commented May 8, 2024

Neat, didn't know about that and now it seems to work, thanks! I have added some tests too.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 5cb9dbd and c1b9fb7.
Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock, !**/*.lock
Files selected for processing (4)
  • crates/language/Cargo.toml (3 hunks)
  • crates/language/src/haskell.rs (1 hunks)
  • crates/language/src/lib.rs (7 hunks)
  • crates/language/src/parsers.rs (2 hunks)
Files skipped from review due to trivial changes (1)
  • crates/language/Cargo.toml
Additional comments not posted (12)
crates/language/src/haskell.rs (5)

6-9: LGTM! The function correctly delegates to test_match_lang with Haskell as the language parameter.


11-14: LGTM! The function correctly delegates to test_non_match_lang with Haskell as the language parameter.


16-26: LGTM! The function tests various Haskell syntax elements. Consider adding more comprehensive tests if needed to cover more complex Haskell syntax.


28-31: LGTM! The function correctly delegates to test_replace_lang with Haskell as the language parameter.


33-68: LGTM! The function tests replacement in Haskell code. Consider adding more comprehensive tests if needed to cover more complex Haskell syntax.

crates/language/src/parsers.rs (1)

35-37: LGTM! The function correctly returns the Tree-sitter language configuration for Haskell.

crates/language/src/lib.rs (6)

16-16: LGTM! The Haskell module has been correctly added.


160-160: LGTM! Haskell has been correctly added to the SupportLang enum.


181-181: LGTM! Haskell has been correctly added to the all_langs function.


234-234: LGTM! Haskell aliases have been correctly added.


279-279: LGTM! Haskell has been correctly added to the execute_lang_method macro.


335-335: LGTM! Haskell file extensions have been correctly added.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c1b9fb7 and 70fb1cd.
Files selected for processing (1)
  • crates/language/src/lib.rs (7 hunks)
Files skipped from review as they are similar to previous changes (1)
  • crates/language/src/lib.rs

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (169d361) to head (70fb1cd).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
+ Coverage   73.36%   73.50%   +0.13%     
==========================================
  Files          76       76              
  Lines        5219     5219              
==========================================
+ Hits         3829     3836       +7     
+ Misses       1390     1383       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HerringtonDarkholme
Copy link
Member

thanks

@HerringtonDarkholme HerringtonDarkholme merged commit 4ec6d04 into ast-grep:main May 9, 2024
4 checks passed
@fwcd fwcd deleted the haskell branch May 13, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add Haskell support
2 participants