Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another weird case #4

Open
mroughan opened this issue Oct 21, 2020 · 1 comment
Open

Another weird case #4

mroughan opened this issue Oct 21, 2020 · 1 comment

Comments

@mroughan
Copy link

"... You wouldn’t hardly know you’re on a boat, Esme. ’Ere, what’s he doing?”

isn't being broken into two sentences:

"... You wouldn’t hardly know you’re on a boat, Esme.
’Ere, what’s he doing?”

@astariul
Copy link
Owner

Hey, thanks for reporting this !

This package is just a port of the python package https://github.com/mediacloud/sentence-splitter, and it seems that in the python package as well the issue is the same...


I think you can open an issue in their repository with your case (or if you don't have time, I can open the issue myself, just let me know !). Hopefully they can provide a fix (and I will port it to this repository as well)

Alternatively, if you can open a PR that fixes it, go ahead !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants