Implement persistency for properties #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorru94
force-pushed
the
persistency
branch
15 times, most recently
from
e1f95d7
to
fafe066
Compare
sorru94
force-pushed
the
persistency
branch
15 times, most recently
from
ca19b5c
to
f17272b
Compare
sorru94
force-pushed
the
persistency
branch
9 times, most recently
from
9538e16
to
3d83046
Compare
harlem88
requested changes
Dec 7, 2023
Signed-off-by: Simone Orru <simone.orru@secomind.com>
Signed-off-by: Simone Orru <simone.orru@secomind.com>
Signed-off-by: Simone Orru <simone.orru@secomind.com>
Signed-off-by: Simone Orru <simone.orru@secomind.com>
Signed-off-by: Simone Orru <simone.orru@secomind.com>
Signed-off-by: Simone Orru <simone.orru@secomind.com>
rgallor
approved these changes
Dec 11, 2023
harlem88
approved these changes
Dec 12, 2023
|
Add some lines about this feature to the changelog. |
harlem88
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Well, I think it's time to enable the clean_session behavior.
astarte-device-sdk-esp32/src/astarte_device.c
Line 375 in e93950e
Since
IDF-5.0 the property has been moved below session field
.session.disable_clean_session = true,Signed-off-by: Simone Orru <simone.orru@secomind.com>
Signed-off-by: Simone Orru <simone.orru@secomind.com>
harlem88
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29