Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-registering a device sets its total sent bytes to zero #776

Closed
Pavinati opened this issue Apr 17, 2023 · 1 comment
Closed

Re-registering a device sets its total sent bytes to zero #776

Pavinati opened this issue Apr 17, 2023 · 1 comment
Labels
app:data_updater_plant This issue or pull request is about astarte_data_updater_plant application app:pairing This issue or pull request is about astarte_pairing application
Milestone
v1.2

Comments

@Pavinati
Copy link
Collaborator

When a device is unregistered and re-registered again its total sent bytes is set to zero but the sent bytes for each interface is left unchanged. To be consistent and avoid confusion pairing should either reset both counters or leave them unchanged.
@Pavinati Pavinati added app:data_updater_plant This issue or pull request is about astarte_data_updater_plant application app:pairing This issue or pull request is about astarte_pairing application labels Apr 17, 2023
@Annopaolo Annopaolo added this to the v1.2 milestone Jan 8, 2024
Annopaolo added a commit to Annopaolo/astarte that referenced this issue Apr 17, 2024
@Annopaolo
Pairing: do not reset device stats on re-registration
41c7d5e 
When a device is unregistered and re-registered,
the total sent bytes/messages counters are set to 0.
This causes an inconsistency with bytes sent on interfaces.
Fix this by not resetting counters. See astarte-platform#776.

Code is duplicated in `queries.ex` because string-based
querying does not allow for much extensibility.

Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
@Annopaolo Annopaolo mentioned this issue Apr 17, 2024
Merged
@Annopaolo
Copy link
Collaborator

Closed by #925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app:data_updater_plant This issue or pull request is about astarte_data_updater_plant application app:pairing This issue or pull request is about astarte_pairing application
Projects
Astarte
Status: Done
Milestone
v1.2
Development

No branches or pull requests
2 participants
@Pavinati @Annopaolo