Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppEngine: Consider microseconds when dealing with timestamps. #621

Merged
merged 1 commit into from Oct 25, 2021
Merged

AppEngine: Consider microseconds when dealing with timestamps. #621

merged 1 commit into from Oct 25, 2021

Conversation

Annopaolo
Copy link
Collaborator

Use utc_datetime_usec instead of utc_datetime in changesets.
Indeed, utc_datetime no longer keeps microseconds information since Ecto 3.0.0 (see https://github.com/elixir-ecto/ecto/blob/master/CHANGELOG.md).
Fix #620.

@Annopaolo
Consider microseconds when querying interfaces with since, to, `s…
4a04def 
…ince_after` params.

Use `utc_datetime_usec` instead of `utc_datetime` in query params changeset
as `utc_datetime` no longer keeps microseconds information since Ecto 3.0.0.
Fix [astarte-platform#620](astarte-platform#620).

Signed-off-by: Arnaldo Cesco <arnaldo.cesco@ispirata.com>
@Annopaolo Annopaolo requested review from rbino and bettio October 7, 2021 14:57
@Annopaolo Annopaolo added API This issue or pull request is about API (e.g. unclear API, new API, API change, deprecation) app:appengine_api This issue or pull request is about astarte_appengine_api application labels Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #621 (2f395f0) into release-1.0 (a99b3bb) will not change coverage.
The diff coverage is n/a.

❗ Current head 2f395f0 differs from pull request most recent head 4a04def. Consider uploading reports for the commit 4a04def to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0     #621   +/-   ##
============================================
  Coverage        67.12%   67.12%           
============================================
  Files              246      246           
  Lines             5457     5457           
============================================
  Hits              3663     3663           
  Misses            1794     1794
Impacted Files Coverage Δ
.../lib/astarte_appengine_api/device/device_status.ex 100.00% <ø> (ø)
...e_appengine_api/device/interface_values_options.ex 85.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fddf0a6...4a04def. Read the comment docs.

@bettio bettio merged commit 76b7861 into astarte-platform:release-1.0 Oct 25, 2021
@Annopaolo Annopaolo mentioned this pull request Sep 30, 2022
Closed
@rbino rbino mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bettio bettio bettio approved these changes

@rbino rbino rbino approved these changes

Assignees
No one assigned
Labels
API This issue or pull request is about API (e.g. unclear API, new API, API change, deprecation) app:appengine_api This issue or pull request is about astarte_appengine_api application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Annopaolo @bettio @rbino