Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if Xandra Cluster options are not provided #62

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

Annopaolo
Copy link
Collaborator

Moreover, standardize opts naming: use xandra_options throughout.

@Annopaolo Annopaolo added minor This issue causes only minor annoyance to the user user experience This issue is about user experience labels Jun 5, 2023
@Annopaolo Annopaolo requested a review from rbino June 5, 2023 13:49
Moreover, standardize opts naming: use 'xandra_options' throughout.

Signed-off-by: Arnaldo Cesco <arnaldo.cesco@secomind.com>
@Annopaolo Annopaolo marked this pull request as ready for review June 5, 2023 14:13
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #62 (f9c491c) into release-1.1 (48ba18a) will increase coverage by 6.09%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release-1.1      #62      +/-   ##
===============================================
+ Coverage        65.24%   71.34%   +6.09%     
===============================================
  Files               10       10              
  Lines              164      164              
===============================================
+ Hits               107      117      +10     
+ Misses              57       47      -10     
Impacted Files Coverage Δ
lib/astarte_data_access.ex 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@rbino rbino merged commit 4c59040 into astarte-platform:release-1.1 Jun 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor This issue causes only minor annoyance to the user user experience This issue is about user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants