Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring dependencies #16

Closed
glkz opened this issue Apr 18, 2015 · 4 comments
Closed

Vendoring dependencies #16

glkz opened this issue Apr 18, 2015 · 4 comments

Comments

@glkz
Copy link
Contributor

glkz commented Apr 18, 2015

@astaxie what is the proposed way for adding external packages to bat. What do you think about using something like godep?

@astaxie
Copy link
Owner

astaxie commented Apr 19, 2015

yea, godep is awesome

@astaxie
Copy link
Owner

astaxie commented Apr 19, 2015

But why do bat need to import third package? if want to import third package, I think interface is the best solution.

@glkz
Copy link
Contributor Author

glkz commented Apr 20, 2015

IMHO, using main package for third party libraries pollutes and complicates main namespace. I think they should be in their own sub-package like httplib.

At this point a tool like godep standardizes that process and makes vendoring easier by rewriting the dependencies' namespaces.

BTW, I asked this mainly because I wanted to add a dependency (ansicolor) to make response formatting code and user interface uniform (i.e windows independent).

@astaxie
Copy link
Owner

astaxie commented Apr 20, 2015

That make sense. it looks ansicolor is cool.

@glkz glkz closed this as completed May 22, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants