http.go: adjust args parse order #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamzhout
force-pushed
the
fix_parse_order
branch
from
c2017da
to
161ed89
Compare
|
Just noticed PR (#43) after submit this one, also try to resolve the same problem. |
when running `bat github.com X-Auth-Token:dGhpcyBpcyBhIGJhc2U2NCB0b2tlbg==`, the X-Auth-Token will fail to be parsed as http header as it contains =, which will be parsed before : just a quick fix, to parse : first
iamzhout
force-pushed
the
fix_parse_order
branch
from
161ed89
to
5725cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running
bat github.com X-Auth-Token:dGhpcyBpcyBhIGJhc2U2NCB0b2tlbg==,the X-Auth-Token will fail to be parsed as http header as it contains =, which will be parsed before :
just a quick fix, to parse : first