Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi package support #220

Closed
wants to merge 4 commits into from
Closed

Add multi package support #220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dee3e23
Add multi package support
danielkarso-pon Mar 29, 2024
7ab599c
npm audit fix + revert manual version set
danielkarso-pon Apr 2, 2024
7fe2bfb
remove root types because it depends on the exports
danielkarso-pon Apr 2, 2024
493ceb8
Export according to https://devblogs.microsoft.com/typescript/announc…
danielkarso-pon Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions fixup
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
cat >dist/cjs/package.json <<!EOF
{
"type": "commonjs"
}
!EOF

cat >dist/mjs/package.json <<!EOF
{
"type": "module"
}
!EOF
13 changes: 10 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
{
"name": "@asteasolutions/zod-to-openapi",
"version": "6.4.0",
"version": "7.0.0",
danielkarso-pon marked this conversation as resolved.
Show resolved Hide resolved
"description": "Builds OpenAPI schemas from Zod schemas",
"main": "dist/index.js",
"main": "dist/cjs/index.js",
"module": "dist/mjs/index.js",
"exports": {
".": {
"import": "./dist/mjs/index.js",
"require": "./dist/cjs/index.js"
}
},
"types": "dist/index.d.ts",
Copy link
Collaborator

@AGalabov AGalabov Apr 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the types be exported from a subfolder now as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that looks like something new (to me) . I followed this guide as to support nodejs and typescript for older and newer versions; https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing

"files": [
"dist",
Expand All @@ -23,7 +30,7 @@
},
"homepage": "https://github.com/asteasolutions/zod-to-openapi",
"scripts": {
"build": "tsc -p tsconfig.build.json",
"build": "rm -rf dist && tsc -p tsconfig.build.json && tsc -p tsconfig.esm.json && ./fixup",
"prepare": "npm run build",
"test": "jest",
"prettier": "prettier --write .",
Expand Down
3 changes: 3 additions & 0 deletions tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"outDir": "dist/cjs"
},
"include": ["src/**/*"]
}
9 changes: 9 additions & 0 deletions tsconfig.esm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"extends": "./tsconfig.build.json",
"compilerOptions": {
"outDir": "dist/mjs",
"target": "esnext",
"module": "esnext",
"moduleResolution": "node"
}
}
Loading