export ESM modules with rollup #222
Conversation
| @@ -14,7 +14,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ | |||
| node-version: [14.x, 16.x, 18.x] | |||
There was a problem hiding this comment.
Rollup uses ??= internally which is not valid in node 14. I don't like the fact that we had to do this change but at the same time I do not think that it is too much of a problem since it is not even activelty supported anymore 🤔 . We might be better off adding 20.x instead imho
There was a problem hiding this comment.
That's weird, are you sure it's not configurable?
There was a problem hiding this comment.
Well that's rollup's source code 🤔 I don't think we can configure that (at least I did not find any options and don't think there are). If we wanted to we probably can introduce Babel and try and convert it to old syntax ... not sure if there's any point.
|
This PR looks good. I would prefer this over my PR! |
Alternative approach to ESM modules using Rollup as dev dependency