You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
added reg_data() function to store data in the proper format to pass to likelihood()
If a field region has more stars than the cluster region, previously the algorithm passed the entire cluster region with no random removal of field stars (to obtain the likelihood of being a cluster member). This resulted in large likelihoods for all stars of being a cluster member, which does not seem right. Now I simply assign zero likelihoods to all stars within the cluster region. This is both faster and statistically correct.
The likelihood used for each star within the cluster region is
and the full Bayesian probability is (A and B are incorrectly swapped in Perren et al. (2015)):
Both L_X and MP_j have terms N_X in them and they cancel out, so the final MP_j equation can be written as:
This means no n_cl term needs to be defined, which (combined with the change mentioned above) greatly improves the results for clusters where the cluster region contains fewer star than the field regions. See for example B48 (left: old DA, right: new one)
Previously the same likelihood between a field region and the full cluster region was calculated bayesda_runs, which made no sense since it is the exact same operation performed over and over again. Now this operation is performed only once per field region, before both for blocks.
The text was updated successfully, but these errors were encountered:
Left over from #24. Things I changed:
likelihood()
core (obviously)reg_data()
function to store data in the proper format to pass tolikelihood()
and the full Bayesian probability is (A and B are incorrectly swapped in Perren et al. (2015)):
Both
L_X
andMP_j
have termsN_X
in them and they cancel out, so the finalMP_j
equation can be written as:This means no
n_cl
term needs to be defined, which (combined with the change mentioned above) greatly improves the results for clusters where the cluster region contains fewer star than the field regions. See for example B48 (left: old DA, right: new one)bayesda_runs
, which made no sense since it is the exact same operation performed over and over again. Now this operation is performed only once per field region, before bothfor
blocks.The text was updated successfully, but these errors were encountered: