Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1 sigma region to the best fit synthetic cluster #460

Closed
Gabriel-p opened this issue Mar 5, 2020 · 0 comments
Closed

Add 1 sigma region to the best fit synthetic cluster #460

Gabriel-p opened this issue Mar 5, 2020 · 0 comments

Comments

@Gabriel-p
Copy link
Contributor

Gabriel-p commented Mar 5, 2020

This is important to avoid people focusing too much on the plotted isochrone, which is not correct.

The correct approach would be as follows:

  1. Randomly sample 1000 synthetic clusters from the 1-sigma regions
  2. Combine them all into a single large 1-sigma synth cluster
  3. Generate a histogram from this data
  4. Color (grey) the observed CMD with it (as done with the Hess diagram) using the same bins used to perform the match
  5. Repeat with a 2-sigma region, and color (pink?) only those bins that are not already colored in the 1 sigma region

Old approach

This is also not a trivial issue. After some investigating, the answer seems to be related to alpha-shapes:

(Old issue: #344)

@Gabriel-p Gabriel-p added this to the v0.3.1 milestone Mar 5, 2020
@Gabriel-p Gabriel-p self-assigned this Mar 5, 2020
Gabriel-p added a commit that referenced this issue Mar 5, 2020
@Gabriel-p Gabriel-p modified the milestones: v0.3.1, v0.3.0 Mar 12, 2020
Gabriel-p added a commit that referenced this issue Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant