New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document why a custom PhantomJS build is necessary #36
Comments
Here is the list of items to be contributed to PhantomJS upstream so that we don't need to maintain a custom build for it, which is the ultimate goal, and relieve the end-users from the extra overhead:
|
This is fantastic information! Can I add it to the README? (Also, could we switch the README to AsciiDoc while we're at it?)
Now I understand why I was having trouble with that when I was using phantomjs directly. I found a workaround by setting the width and height to the computed width and height (which is odd that it works), but having support out of the box would be so much better. |
@mojavelinux you have my blessing (both for the README update and the AsciiDoc migration 🎉 ), making it clear the ultimate goal is to avoid having to deal with that astefanutti/phantomjs fork. |
Excellent! I'll send a PR as soon as I get a chance. |
PR sent! |
resolves #36 document why DeckTape uses a PhantomJS fork
Document the reason(s) why decktape relies on a custom build of PhantomJS. The documentation will serve two purposes:
My understanding is that the patch to PhantomJS is to provide a printer module that can combine multiple PDF pages into one. By default, PhantomJS can only capture and write one PDF page to file at a time. Since there is no way to merge PDF files using JavaScript, there's no other easy solution besides patching PhantomJS to provide this functionality.
Where are we with the upstream request? Are they considering adding this new module?
The text was updated successfully, but these errors were encountered: