Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NueDeck #188

Merged
merged 3 commits into from Jul 3, 2019
Merged

Conversation

twitwi
Copy link
Contributor

@twitwi twitwi commented Jul 3, 2019

This plugin is for NueDeck (a reboot of deck.js (and many extensions), using Vue.js, https://github.com/twitwi/nuedeck )

I don't know what is the policy for including new plugins into the main repo:

  • NueDeck is currently very new, is this blocking?
  • should I update the decktape readme for the PR?
  • also, is there a way for a plugin to change the default "pause"?

Thanks for working on decktape.

A reboot of deck.js (and many extensions), using Vue.js
https://github.com/twitwi/nuedeck
@astefanutti
Copy link
Owner

Thanks a lot for the PR.

I don't know what is the policy for including new plugins into the main repo:

  • NueDeck is currently very new, is this blocking?

Not at all.

  • should I update the decktape readme for the PR?

Yes, I think you can update the list of supported plugins and the CLI help output.

  • also, is there a way for a plugin to change the default "pause"?

Currently no. I was thinking we could add an optional API, as it could help speeding up the export for some plugins a lot. Could you create an issue to track that enhancement?

@twitwi
Copy link
Contributor Author

twitwi commented Jul 3, 2019

Thanks, I opened #189

@twitwi
Copy link
Contributor Author

twitwi commented Jul 3, 2019

Readme updated! (with some pain)

@astefanutti
Copy link
Owner

Thanks, sorry for the poor man grid layout :)

Would you mind updating the CLI help by adding nuedeck to the possible values for the command?

@twitwi
Copy link
Contributor Author

twitwi commented Jul 3, 2019

no problem,
done

@astefanutti astefanutti merged commit d0d9410 into astefanutti:master Jul 3, 2019
@astefanutti
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants