Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README for Remark JS #206

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Update README for Remark JS #206

merged 2 commits into from
Mar 31, 2020

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Mar 30, 2020

Fixes README following comment on issue #157 (comment)

astefanutti
astefanutti requested changes Mar 30, 2020
View reviewed changes
Copy link
Owner

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! I've just commented on the description of the error. If you can amend it, then I'll merge the PR.

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
sunny
sunny commented Mar 31, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
@sunny
Copy link
Contributor Author

sunny commented Mar 31, 2020 •
edited

Much clearer indeed!

@sunny sunny requested a review from astefanutti March 31, 2020 12:04
@astefanutti astefanutti merged commit 940686d into astefanutti:master Mar 31, 2020
@astefanutti
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sunny @astefanutti