Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PDF dir if it doesn't exist #218

Merged
merged 2 commits into from Aug 11, 2020
Merged

Create PDF dir if it doesn't exist #218

merged 2 commits into from Aug 11, 2020

Conversation

ebriand
Copy link
Contributor

@ebriand ebriand commented Aug 11, 2020

Hey 馃憢

This is a small PR to automatically create the PDF dir if it doesn't exist 馃憤

@ebriand ebriand mentioned this pull request Aug 11, 2020
Merged
astefanutti
astefanutti reviewed Aug 11, 2020
View reviewed changes
Copy link
Owner

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Just added a comment about using the recursive option for fs.mkdirSync.

decktape.js Outdated Show resolved Hide resolved
astefanutti
astefanutti approved these changes Aug 11, 2020
View reviewed changes
Copy link
Owner

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@astefanutti astefanutti merged commit de3d37d into astefanutti:master Aug 11, 2020
@ebriand ebriand deleted the patch-1 branch August 13, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ebriand @astefanutti