Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement component-level access control mechanism #61

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

StevenJiang1110
Copy link
Collaborator

No description provided.

@StevenJiang1110 StevenJiang1110 force-pushed the components branch 2 times, most recently from cc4c8b5 to b98df13 Compare February 8, 2023 11:56
Copy link
Contributor

@tatetian tatetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! The code for the component system looks neat! I raised some minor issues.

analysis/target
analysis/Cargo.lock
tests/*/Cargo.lock
tests/*/target
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cargo.lock files under tests are ignored, but they are still added for version control. Is this a mistake?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since in this case, each library under tests is an independent crate, they will generate an Cargo.lock when execute cargo component check on it. But such files can be removed at last step of test instead of added to .gitignore. I removed these lines from .gitignore.

@@ -0,0 +1,246 @@
//! This implementation is from rust clippy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the license of rust clippy as the file header. Remember to add Ant Group as the latest copyright holder.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -0,0 +1,129 @@
//! This implementation is from rust clippy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the license of rust clippy as the file header. Remember to add Ant Group as the latest copyright holder.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

README.md Outdated
@@ -55,6 +55,15 @@ all developmennt tools are installed.
make setup
```

Then, install some standalone tools.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, install some standalone tools (e.g., `cargo-component-check`) under the project directory.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@tatetian tatetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@tatetian tatetian merged commit f0d27c0 into asterinas:main Feb 14, 2023
@tatetian tatetian mentioned this pull request Feb 14, 2023
10 tasks
@tatetian tatetian changed the title add cargo-component Implement component-level access control mechanism Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants