Timer status display #537
Timer status display #537
Conversation
BrianHicks
force-pushed
the
feature/incremental-status-display
branch
from
f083d20
to
2aa1f44
Compare
| slog.Info("got status") | ||
| } | ||
|
|
||
| if resp.Run == pb.StatusResponse_FINISHED { |
There was a problem hiding this comment.
This could probably be moved to the above if else block since it is regarding resp.Run.
There was a problem hiding this comment.
Changed to switch statements in both cases. Gotta take my own advice :D
| @@ -109,6 +114,7 @@ can be done separately to see what needs to be changed before execution.`, | |||
| "id": resp.Meta.Id, | |||
| }) | |||
| if resp.Run == pb.StatusResponse_STARTED { | |||
| timer.AddTimer(resp.Meta.Id + ": " + resp.Stage.String()) | |||
| slog.Info("got status") | |||
| } else { | |||
| slog.Debug("got status") | |||
There was a problem hiding this comment.
Did you intend to change Debug to Info here also?
There was a problem hiding this comment.
I actually forgot to change it back to Debug... I was just debugging.
| func (td *TimerDisplay) Message() string { | ||
| td.once.Do(td.init) | ||
|
|
||
| out := "\nActive:\n" |
There was a problem hiding this comment.
I noticed this output is sometimes displayed on one line and sometimes displayed twice, with the second a few lines below. The second instance flashes on and off the screen.
There was a problem hiding this comment.
Yes, that's a race condition in the library we're using. I'm not sure what's causing it, but it seems to be an issue with multi-line displays. Unfortunately, it looks awful on one line so I think we're just going to have to deal with it :\
…isplay Timer status display
This adds an incremental status display for long-running tasks.
Fixes #269