Skip to content

Commit

Permalink
contrib: rc.archlinux.asterisk uses invalid redirect.
Browse files Browse the repository at this point in the history
`rc.archlinux.asterisk`, which explicitly requests bash in its
shebang, uses the following command syntax:

  ${DAEMON} -rx "core stop now" > /dev/null 2&>1

The intent of which is to execute:

  ${DAEMON} -rx "core stop now"

While sending both stdout and stderr to `/dev/null`. Unfortunately,
because the `&` is in the wrong place, bash is interpreting the `2` as
just an additional argument to the `$DAEMON` command and not as a file
descriptor and proceeds to use the bashism `&>` to send stderr and
stdout to a file named `1`.

So we clean it up and just use bash's shortcut syntax.

Issue raised and a fix suggested (but not used) by peutch on GitHub¹.

ASTERISK-30449 #close

1. asterisk/asterisk#31

Change-Id: Ie279bf4efb4d95cbf507313483d316e977303d19
(cherry picked from commit 5283d44)
  • Loading branch information
seanbright authored and asteriskteam committed May 8, 2023
1 parent d9e8688 commit 64135fb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion contrib/init.d/rc.archlinux.asterisk
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ case "$1" in
stop)
if [ -r ${ASTVARRUNDIR}/asterisk.pid ]; then
stat_busy "Stopping Asterisk..."
${DAEMON} -rx "core stop now" > /dev/null 2&>1
${DAEMON} -rx "core stop now" &>/dev/null
if [ $? -gt 0 ]; then
stat_fail
else
Expand Down

0 comments on commit 64135fb

Please sign in to comment.